[llvm-commits] [llvm] r124995 - in /llvm/trunk: lib/Target/ARM/ARMAsmPrinter.cpp lib/Target/ARM/ARMBuildAttrs.h test/CodeGen/ARM/2010-09-29-mc-asm-header-test.ll test/CodeGen/ARM/2010-10-19-mc-elf-objheader.ll

[Anton Korobeynikov]

Hello Jason,

> +  if (CPUString == "cortex-a8" ||
> +      Subtarget->isCortexA8()) {
> +    AttrEmitter->EmitTextAttribute(ARMBuildAttrs::CPU_name, "CORTEX-A8");
> +    AttrEmitter->EmitAttribute(ARMBuildAttrs::CPU_arch, ARMBuildAttrs::v7);
> +    AttrEmitter->EmitAttribute(ARMBuildAttrs::CPU_arch_profile,
> +                               ARMBuildAttrs::ApplicationProfile);
> +    AttrEmitter->EmitAttribute(ARMBuildAttrs::ARM_ISA_use,
> +                               ARMBuildAttrs::Allowed);
> +    AttrEmitter->EmitAttribute(ARMBuildAttrs::THUMB_ISA_use,
> +                               ARMBuildAttrs::AllowThumb32);
> +    // Fixme: figure out when this is emitted.
> +    //AttrEmitter->EmitAttribute(ARMBuildAttrs::WMMX_arch,
> +    //                           ARMBuildAttrs::AllowWMMXv1);
Can't we deduce these attributes from -mattr stuff? I believe
subtarget has all necessary stuff wrt ISA and CPU arch. You might only
need to do some custom stuff for profile.

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University