[llvm-commits] [llvm] r124694 - /llvm/trunk/lib/Target/ARM/ARMJITInfo.cpp

[Renato Golin]

Great, thanks!

--renato
________________________________________
From: Bob Wilson [bob.wilson at apple.com]
Sent: 02 February 2011 17:26
To: Renato Golin
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [llvm] r124694 - /llvm/trunk/lib/Target/ARM/ARMJITInfo.cpp

On Feb 2, 2011, at 3:14 AM, Renato Golin wrote:

> Hi Bob,
>
> Two things...
>
> First, silly comment but, would be good to update the comment just above (all in one pop) to reflect the change.

Sure, I can do that.

>
> Second, I'm not a JIT expert (nor I know the full context), but does that mix with the requirement of using BX LR (for ARM/Thumb switch)? Or the JOT never mix them up anyway?

Last time I checked (quite a while ago) the JIT only supported ARM.  The "ldr pc" instruction will support interworking in v5T and beyond, and it's no worse in that respect than the ldm instruction used before.

I'm not at all familiar with this code, but as far as I can tell, it is supposed to branch with _all_ of the registers restored to their original values, including LR.  So that pretty much rules out using "bx lr"....

At least this way it will avoid the build failure.

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.