[llvm-commits] [llvm] r124282 - /llvm/trunk/lib/Analysis/ScalarEvolution.cpp

[Nick Lewycky]

Duncan Sands wrote:
> Hi Nick,
>
>> Fix memory corruption. If one of the SCEV creation functions calls another but
>> doesn't return immediately after then the insert position in UniqueSCEVs will
>> be out of date. No test because this is a memory corruption issue. Fixes PR9051!
>
> thanks for fixing it.  Adding a test is still useful since the valgrind
> buildbots should spot the memory corruption if it ever comes back.

The only testcase I have requires running 9 optimization passes 
including instcombine and inlining. Changes in any of those or could 
cause this testcase to change pass/fail. I don't think that's a useful 
testcase to commit; it won't be testing for this problem in the near 
future when those other passes change.

And I can't write anything more targeted since it's a memory corruption 
issue.

Nick