[llvm-commits] Patches to build EFI with clang/llvm

Carl Norum carl.norum at apple.com
Wed Jan 26 14:17:43 PST 2011


On Jan 26, 2011, at 7:26 AM, NAKAMURA Takumi wrote:
> Carl and Jakob,
> 
> I have committed win64 tailcall stuff today.

Great - I synced up, applied my MachO patches, and built EFI.  The resulting ROM is working here to boot my test machine.

> I think isTargetCOFF() would be annoying.
> We have never met we would use Win32/Win64 ABI not for PECOFF targets.
> 
> Carl's win32-macho patch is okay in gross for me for now. :)

I'll try to look at those suspicious conditionals that Jakob pointed out yesterday and see if I can clean them up.  As I mentioned before, I'm not that familiar with the code or the changes, but I'll see what I can do.

> In future, we might restructure triplets for win32-related system.
> IMHO, eg. -win32 should not present Microsoft-specific toolchain, but
> generic Win32 ABI and API.
> Microsoft environments might be presented as "-msvcrt[0-9]*", though
> mingw uses msvcrt.dll.
> I will post a topic for win32 stuff if someone had interest.

That is a fantastic idea.

-- Carl





More information about the llvm-commits mailing list