[llvm-commits] [PATCH]: patch for .cfi register parsing

[Rafael Ávila de Espíndola]

On 11-01-24 12:55 PM, Roman Divacky wrote:
> Hi,
>
> some .cfi directives take register as an argument, ie:
>
> .cfi_def_cfa_register %ebp
>
> The attached patch implements that. The patch makes ParseRegister
> method in TargetAsmParser public. I made that change only in
> X86 in that patch as I want some comment on whether this is the
> correct thing to do.

It is probably on the right direction, but are you sure this is giving 
you the correct numbers? You should use the dwarf numbers, not the 
internal numbers used by llvm.

It is probably also a good idea to factor out a 
ParseRegisterOrRegisterNumber method.

Last but not least, include tests :-)

> Thank you!
>
> roman
>

Cheers,
Rafael