[llvm-commits] Patches to build EFI with clang/llvm

Carl Norum carl.norum at apple.com
Tue Jan 25 17:23:49 PST 2011


On Jan 25, 2011, at 4:47 PM, Jakob Stoklund Olesen wrote:
> On Jan 25, 2011, at 4:37 PM, Carl Norum wrote:
>> On Jan 25, 2011, at 4:32 PM, Jakob Stoklund Olesen wrote:
>>> Could you separate the Mach-O related changes from the Win64 tail call fixes, please?
>> 
>> I'll see what I can do.
> 
> Thanks!

MachO-related changes are attached as "macho.patch".  I think I cleared out all the tail-call stuff correctly.

>>> Takumi recently submitted a patch to do the exact same thing. I think he managed to avoid the new instructions. I think his solution was better, assuming it works for you.
>> 
>> It very well might; I sort of inherited this code, so I'll have to dig around a bit before figuring that all out.  Has that patch gone into TOT, and if not, where can I get it from?
> 
> I think this was his latest attempt: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20110110/115159.html
> The changes haven't been committed, AFAIK.

This patch worked great here - I haven't done exhaustive testing, but I could build EFI and boot/sleep/wake a couple of machines with the resulting binaries.  Is it expected that these patches will get committed sometime in the near future?

Let me know what you think about the attached Mach-O patches! 

-- Carl


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110125/2e4bc85b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: macho.patch
Type: application/octet-stream
Size: 7234 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110125/2e4bc85b/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110125/2e4bc85b/attachment-0001.html>


More information about the llvm-commits mailing list