[llvm-commits] [Patch][CMake] Implement --enable-libffi option in CMake build.

arrowdodger 6yearold at gmail.com
Fri Jan 21 06:42:21 PST 2011


On Fri, Jan 21, 2011 at 5:15 PM, Óscar Fuentes <ofv at wanadoo.es> wrote:

> I guess you meant FFI_LIBRARY_DIR
>
Right, fixed.

This is not good style. Using full paths for adding libraries to the
> link command should be avoided, otherwise the resulting command would be
> very hard to read. Please use the something like the code that I sent
> you on our private discussion.
>
The problem is that find_library sets its output variable to something like
"/usr/local/lib/libffi.so". I'm not sure how to get "/usr/local/lib" part
from it.

You need to declare FFI_INCLUDE_DIR and FFI_LIBRARY_DIR as user-settable
> variables:
>
> set(FFI_LIBRARY_DIR "" CACHE PATH "<description>")
>
> You need to document LLVM_ENABLE_FFI on docs/CMake.html too. Mention
> FFI_LIBRARY_DIR and FFI_INCLUDE_DIR there.
>
Will do.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110121/c490c3d6/attachment.html>


More information about the llvm-commits mailing list