[llvm-commits] [PATCH] ARM bkpt instruction!

Daniel Dunbar daniel at zuster.org
Mon Jan 17 17:25:35 PST 2011


Looks fine, at least it is no worse than existing hack set.

 - Daniel

On Mon, Jan 17, 2011 at 10:11 AM, Bruno Cardoso Lopes
<bruno.cardoso at gmail.com> wrote:
> Ping,
> AttachedĀ is an updated version of the patch!
>
> On Tue, Jan 11, 2011 at 10:28 PM, Bruno Cardoso Lopes
> <bruno.cardoso at gmail.com> wrote:
>>
>> Hi Anton,
>>
>> On Mon, Jan 10, 2011 at 5:39 PM, Anton Korobeynikov
>> <anton at korobeynikov.info> wrote:
>> > Hi Bruno,
>> >
>> >> This patch fix the asm parsing for the thumb1 bkpt instruction!
>> >> Ok to commit?
>> > Is it possible to make patch more generic somehow, e.g. for other
>> > non-predicable instructions (if any)?
>>
>> The problem here is that the cond code operand is created during
>> ParseInstruction, while any MI info will only be available in
>> MatchAndEmitInstruction. With MI info we would be able to do something
>> better, for example: creating a TSFlag for Encoding16 or mark
>> instructions with a NonPredicable bit, but that's not possible. I'm
>> not aware of a more generic solution right now, but I'm open to ideas
>> :)
>>
>> --
>> Bruno Cardoso Lopes
>> http://www.brunocardoso.cc
>
>
>
> --
> Bruno Cardoso Lopes
> http://www.brunocardoso.cc
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>




More information about the llvm-commits mailing list