[llvm-commits] [PATCH] simplify construction and destruction of Uses

[Gabor Greif]

Am 13.01.2011 um 22:25 schrieb Chris Lattner:

>
> On Jan 13, 2011, at 8:13 AM, Jay Foad wrote:
>
>> This patch makes sure that we consistently use placement new to
>> construct Uses, and that we destroy them before the memory is
>> deallocated. There should be no change in behaviour (because Use's
>> constructor did nothing, and its destructor was equivalent to
>> Use::set(0)) but I think it is more correct.
>>
>> The patch also simplifies User::dropHungOffUses() and its callers.
>
> This patch looks good to me.  Gabor, can you look at this too?

Yeah, all looks like equivalence simplifications to me, save the
check  for NULL before calling zap(). But I believe that the passed
operand lists are non-null anyway, and if not, the testers will notice
soon enough :-)

OK to commit. Good work!

Cheers,

	Gabor


>
> -Chris