[llvm-commits] [llvm] r123419 - in /llvm/trunk/lib/CodeGen: MachineBasicBlock.cpp PHIElimination.cpp
Jakob Stoklund Olesen
stoklund at 2pi.dk
Thu Jan 13 17:17:54 PST 2011
Author: stoklund
Date: Thu Jan 13 19:17:53 2011
New Revision: 123419
URL: http://llvm.org/viewvc/llvm-project?rev=123419&view=rev
Log:
Try again to teach getFirstTerminator() about debug values.
Fix some callers to better deal with debug values.
Modified:
llvm/trunk/lib/CodeGen/MachineBasicBlock.cpp
llvm/trunk/lib/CodeGen/PHIElimination.cpp
Modified: llvm/trunk/lib/CodeGen/MachineBasicBlock.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineBasicBlock.cpp?rev=123419&r1=123418&r2=123419&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/MachineBasicBlock.cpp (original)
+++ llvm/trunk/lib/CodeGen/MachineBasicBlock.cpp Thu Jan 13 19:17:53 2011
@@ -155,11 +155,22 @@
}
MachineBasicBlock::iterator MachineBasicBlock::getFirstTerminator() {
- iterator I = end();
- while (I != begin() && (--I)->getDesc().isTerminator())
- ; /*noop */
- if (I != end() && !I->getDesc().isTerminator()) ++I;
- return I;
+ iterator B = begin(), I = end();
+ iterator Term = I;
+ while (I != B) {
+ --I;
+ // Ignore any debug values after the first terminator.
+ if (I->isDebugValue())
+ continue;
+ // Stop once we see a non-debug non-terminator.
+ if (!I->getDesc().isTerminator())
+ break;
+ // Earliest terminator so far.
+ Term = I;
+ }
+ // Return the first terminator, or end().
+ // Everything after Term is terminators and debug values.
+ return Term;
}
MachineBasicBlock::iterator MachineBasicBlock::getLastNonDebugInstr() {
Modified: llvm/trunk/lib/CodeGen/PHIElimination.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/PHIElimination.cpp?rev=123419&r1=123418&r2=123419&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/PHIElimination.cpp (original)
+++ llvm/trunk/lib/CodeGen/PHIElimination.cpp Thu Jan 13 19:17:53 2011
@@ -339,6 +339,8 @@
#ifndef NDEBUG
for (MachineBasicBlock::iterator TI = llvm::next(Term);
TI != opBlock.end(); ++TI) {
+ if (TI->isDebugValue())
+ continue;
assert(!TI->readsRegister(SrcReg) &&
"Terminator instructions cannot use virtual registers unless"
"they are the first terminator in a block!");
@@ -347,9 +349,13 @@
} else if (reusedIncoming || !IncomingReg) {
// We may have to rewind a bit if we didn't insert a copy this time.
KillInst = Term;
- while (KillInst != opBlock.begin())
- if ((--KillInst)->readsRegister(SrcReg))
+ while (KillInst != opBlock.begin()) {
+ --KillInst;
+ if (KillInst->isDebugValue())
+ continue;
+ if (KillInst->readsRegister(SrcReg))
break;
+ }
} else {
// We just inserted this copy.
KillInst = prior(InsertPos);
More information about the llvm-commits
mailing list