[llvm-commits] [llvm] r122979 - in /llvm/trunk/lib/CodeGen/SelectionDAG: LegalizeIntegerTypes.cpp LegalizeTypes.cpp LegalizeTypes.h

[Eric Christopher]

On Jan 6, 2011, at 2:45 PM, Duncan Sands wrote:

> Hi Eric,
> 
>> +std::pair<SDValue, SDValue>  DAGTypeLegalizer::ExpandAtomic(SDNode *Node) {
> 
> why not put this function in LegalizeIntegerTypes?  It doesn't seem to be of
> general utility.  Are you planning to use it from some other LegalizeXYZTypes
> file?
> 
>> +	std::pair<SDValue, SDValue>  ExpandAtomic(SDNode *Node);
>> +
> 
> Then you wouldn't need this declaration either.

OK, I just moved the function and didn't pull it out of the class, otherwise I'd have needed to forward declare a few things and pass in a <this> into ExpandAtomic for a single use… ick. 

It is moved now though :)

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110110/7ffc2183/attachment.html>