[llvm-commits] [llvm] r123034 - in /llvm/trunk: lib/Transforms/InstCombine/InstCombineSelect.cpp test/Transforms/InstCombine/select.ll

[Cameron Zwarich]

On Jan 8, 2011, at 7:21 AM, Tobias Grosser wrote:

> On 01/08/2011 05:56 AM, Frits van Bommel wrote:
>> On Sat, Jan 8, 2011 at 2:44 AM, Benjamin Kramer
>> <benny.kra at googlemail.com>  wrote:
>>> On 07.01.2011, at 22:33, Tobias Grosser wrote:
>>>> +          Constant *sextRHS = ConstantExpr::getSExt(AdjustedRHS,
>>>> +                                                    SI.getType());
>>> 
>>> This line (ConstantExpr::getSExt) hits an assertion failure in some files in the test suite
>> 
>>> And the offending IR is:
>>>  %175 = sitofp i32 %j.3 to double
>>>  %174 = icmp slt i32 %j.3, 2
>>>  %176 = select i1 %174, double 2.000000e+00, double %175
>> 
>> Fixed in r123061.
> Hey Frits,
> 
> thanks a lot.

Even with r123061, I still see the following on one of my tests against SPEC. I guess I should make a reduction for you guys.

Running 'lis' test on '464.h264ref' program
opt -O2 -stats -disable-output Output/464.h264ref.linked.rbc
WARNING: While resolving call to function 'find_distortion' arguments were dropped!
WARNING: While resolving call to function 'find_distortion' arguments were dropped!
WARNING: While resolving call to function 'init_dpb' arguments were dropped!
WARNING: While resolving call to function 'GetConfigFileContent' arguments were dropped!
WARNING: While resolving call to function 'GetConfigFileContent' arguments were dropped!
WARNING: While resolving call to function 'SliceHeader' arguments were dropped!
WARNING: While resolving call to function 'proceed2nextMacroblock' arguments were dropped!
WARNING: While resolving call to function 'proceed2nextMacroblock' arguments were dropped!
WARNING: While resolving call to function 'proceed2nextMacroblock' arguments were dropped!
Instruction does not dominate all uses!
  %96 = sext i32 %93 to i64
  %95 = icmp sgt i64 %96, 51
Instruction does not dominate all uses!
  %95 = icmp sgt i64 %96, 51
  %phitmp15 = select i1 %95, i64 51, i64 %96
Instruction does not dominate all uses!
  %106 = sext i32 %103 to i64
  %105 = icmp sgt i64 %106, 51
Instruction does not dominate all uses!
  %105 = icmp sgt i64 %106, 51
  %phitmp16 = select i1 %105, i64 51, i64 %106
Instruction does not dominate all uses!
  %121 = sext i32 %118 to i64
  %120 = icmp sgt i64 %121, 51
Instruction does not dominate all uses!
  %120 = icmp sgt i64 %121, 51
  %phitmp = select i1 %120, i64 51, i64 %121
Broken module found, compilation aborted!
0  opt               0x0000000100484442 PrintStackTrace(void*) + 34
1  opt               0x0000000100484919 SignalHandler(int) + 697
2  libSystem.B.dylib 0x00007fff83cd467a _sigtramp + 26
3  libSystem.B.dylib 0x0000000101c68560 _sigtramp + 2113486592
4  opt               0x0000000100039c06 abort + 22
5  opt               0x00000001004549ef (anonymous namespace)::Verifier::runOnFunction(llvm::Function&) + 3423
6  opt               0x000000010042a570 llvm::FPPassManager::runOnFunction(llvm::Function&) + 656
7  opt               0x000000010022016a (anonymous namespace)::CGPassManager::runOnModule(llvm::Module&) + 1402
8  opt               0x000000010042bdbd llvm::MPPassManager::runOnModule(llvm::Module&) + 557
9  opt               0x000000010042c0c3 llvm::PassManagerImpl::run(llvm::Module&) + 243
10 opt               0x000000010042c15d llvm::PassManager::run(llvm::Module&) + 13
11 opt               0x0000000100044daf main + 3807
12 opt               0x000000010003be44 start + 52
Stack dump:
0.	Program arguments: opt -O2 -stats -disable-output Output/464.h264ref.linked.rbc 
1.	Running pass 'CallGraph Pass Manager' on module 'Output/464.h264ref.linked.rbc'.
2.	Running pass 'Module Verifier' on function '@EdgeLoop'
make[4]: *** [test.lis.464.h264ref] Illegal instruction
make[3]: *** [464.h264ref/.maketest] Error 2
make[2]: *** [CINT2006/.maketest] Error 2
make[1]: *** [SPEC/.maketest] Error 2
make: *** [External/.maketest] Error 2