[llvm-commits] [llvm] r123064 - in /llvm/trunk/lib: CodeGen/GCStrategy.cpp CodeGen/StackProtector.cpp CodeGen/UnreachableBlockElim.cpp Transforms/Scalar/CodeGenPrepare.cpp Transforms/Utils/Local.cpp

[Chris Lattner]

On Jan 8, 2011, at 9:01 AM, Cameron Zwarich wrote:

> Author: zwarich
> Date: Sat Jan  8 11:01:52 2011
> New Revision: 123064
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=123064&view=rev
> Log:
> Make more passes preserve dominators (or state that they preserve dominators if
> they all ready do). This removes two dominator recomputations prior to isel,
> which is a 1% improvement in total llc time for 403.gcc.

Very nice.

> The only potentially suspect thing is making GCStrategy recompute dominators if
> it used a custom lowering strategy.

This is definitely the right way to go.  Someone who cares about the compile time of the GC logic can improve it to update whenever they care enough. :)

-Chris