[llvm-commits] [llvm] r122907 - /llvm/trunk/include/llvm/Support/StandardPasses.h

Bob Wilson bob.wilson at apple.com
Wed Jan 5 13:16:50 PST 2011


Author: bwilson
Date: Wed Jan  5 15:16:50 2011
New Revision: 122907

URL: http://llvm.org/viewvc/llvm-project?rev=122907&view=rev
Log:
Revert svn 122743, removing the instcombine pass that was replaced by earlycse.
My i386 llvm-gcc nightly tester found a regression for
SingleSource/Benchmarks/McGill/chomp that a bisect blamed on 122743.
That seems strange but apparently the combination of earlycse and instcombine
did something bad.  Chris says he intended to remove the instcombine pass, so
let's go ahead and try that.  We'll see if there are any performance losses.

Modified:
    llvm/trunk/include/llvm/Support/StandardPasses.h

Modified: llvm/trunk/include/llvm/Support/StandardPasses.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/StandardPasses.h?rev=122907&r1=122906&r2=122907&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Support/StandardPasses.h (original)
+++ llvm/trunk/include/llvm/Support/StandardPasses.h Wed Jan  5 15:16:50 2011
@@ -132,7 +132,6 @@
     PM->add(createEarlyCSEPass());              // Catch trivial redundancies
     if (OptimizeBuiltins)
       PM->add(createSimplifyLibCallsPass());    // Library Call Optimizations
-    PM->add(createInstructionCombiningPass());  // Cleanup for scalarrepl.
     PM->add(createJumpThreadingPass());         // Thread jumps.
     PM->add(createCorrelatedValuePropagationPass()); // Propagate conditionals
     PM->add(createCFGSimplificationPass());     // Merge & remove BBs





More information about the llvm-commits mailing list