[llvm-commits] [llvm] r122743 - /llvm/trunk/include/llvm/Support/StandardPasses.h

[Evan Cheng]

On Jan 3, 2011, at 3:33 PM, Chris Lattner wrote:

> 
> On Jan 3, 2011, at 3:28 PM, Evan Cheng wrote:
> 
>> 
>> On Jan 3, 2011, at 10:11 AM, Chris Lattner wrote:
>> 
>>> 
>>> On Jan 2, 2011, at 11:53 PM, Evan Cheng wrote:
>>> 
>>>> Author: evancheng
>>>> Date: Mon Jan  3 01:53:18 2011
>>>> New Revision: 122743
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=122743&view=rev
>>>> Log:
>>>> Undo what looks like accidental removal of an instcombine pass in r122740.
>>> 
>>> This wasn't accidental, is there a reason you want an instcombine here?
>> 
>> No reason other than it was there before r122740 (which is only supposed to add the earlycse pass). Are you certain there is no loss from removing this instcombine pass?
> 
> I'm not certain that there is no loss in no cases, but the performance comparisons I did had it removed and the intention of earlycse is to subsume that particular run of instcombine.

I can remove it again if you feel comfortable with it. 

Evan

> 
> -Chris