[llvm-commits] [llvm] r122740 - /llvm/trunk/include/llvm/Support/StandardPasses.h

[Chris Lattner]

On Jan 2, 2011, at 11:37 PM, Roman Divacky wrote:
> On Mon, Jan 03, 2011 at 06:19:09AM -0000, Chris Lattner wrote:
>> +++ llvm/trunk/include/llvm/Support/StandardPasses.h Mon Jan  3 00:19:09 2011
>> @@ -129,9 +129,9 @@
>> 
>>     // Start of function pass.
>>     PM->add(createScalarReplAggregatesPass());  // Break up aggregate allocas
>> +    PM->add(createEarlyCSEPass());              // Catch trivial redundancies
>>     if (SimplifyLibCalls)
>>       PM->add(createSimplifyLibCallsPass());    // Library Call Optimizations
>> -    PM->add(createInstructionCombiningPass());  // Cleanup for scalarrepl.
> 
> was removing the InstructionCombiningPass intended?
> 
> gnu screen compiles to 344992 bytes without InstructionCombiningPass (as in trunk)
> but to 344624 bytes with the InstructionCombiningPass kept...

Hi Roman,

Can you please file a bug with a .i file (along with the flags you're building with) for one of the files that is smaller with instcombine?  It is entirely possible that an extra loop gets unrolled now or something like that, but I'd like to verify.  Thanks!

-Chris