[llvm-commits] [llvm] r122743 - /llvm/trunk/include/llvm/Support/StandardPasses.h

[Evan Cheng]

On Jan 3, 2011, at 10:11 AM, Chris Lattner wrote:

> 
> On Jan 2, 2011, at 11:53 PM, Evan Cheng wrote:
> 
>> Author: evancheng
>> Date: Mon Jan  3 01:53:18 2011
>> New Revision: 122743
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=122743&view=rev
>> Log:
>> Undo what looks like accidental removal of an instcombine pass in r122740.
> 
> This wasn't accidental, is there a reason you want an instcombine here?

No reason other than it was there before r122740 (which is only supposed to add the earlycse pass). Are you certain there is no loss from removing this instcombine pass?

Evan

> 
> -Chris
> 
>> 
>> Modified:
>>   llvm/trunk/include/llvm/Support/StandardPasses.h
>> 
>> Modified: llvm/trunk/include/llvm/Support/StandardPasses.h
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/StandardPasses.h?rev=122743&r1=122742&r2=122743&view=diff
>> ==============================================================================
>> --- llvm/trunk/include/llvm/Support/StandardPasses.h (original)
>> +++ llvm/trunk/include/llvm/Support/StandardPasses.h Mon Jan  3 01:53:18 2011
>> @@ -132,6 +132,7 @@
>>    PM->add(createEarlyCSEPass());              // Catch trivial redundancies
>>    if (SimplifyLibCalls)
>>      PM->add(createSimplifyLibCallsPass());    // Library Call Optimizations
>> +    PM->add(createInstructionCombiningPass());  // Cleanup for scalarrepl.
>>    PM->add(createJumpThreadingPass());         // Thread jumps.
>>    PM->add(createCorrelatedValuePropagationPass()); // Propagate conditionals
>>    PM->add(createCFGSimplificationPass());     // Merge & remove BBs
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>