[llvm-commits] [llvm] r122745 - /llvm/trunk/lib/Transforms/Utils/SimplifyInstructions.cpp

[Duncan Sands]

Author: baldrick
Date: Mon Jan  3 04:50:04 2011
New Revision: 122745

URL: http://llvm.org/viewvc/llvm-project?rev=122745&view=rev
Log:
Speed up instsimplify by about 10-15% by not bothering to retry
InstructionSimplify on instructions that didn't change since the
last time round the loop.

Modified:
    llvm/trunk/lib/Transforms/Utils/SimplifyInstructions.cpp

Modified: llvm/trunk/lib/Transforms/Utils/SimplifyInstructions.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/SimplifyInstructions.cpp?rev=122745&r1=122744&r2=122745&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/SimplifyInstructions.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/SimplifyInstructions.cpp Mon Jan  3 04:50:04 2011
@@ -19,6 +19,7 @@
 #include "llvm/Pass.h"
 #include "llvm/Type.h"
 #include "llvm/ADT/DepthFirstIterator.h"
+#include "llvm/ADT/SmallPtrSet.h"
 #include "llvm/ADT/Statistic.h"
 #include "llvm/Analysis/Dominators.h"
 #include "llvm/Analysis/InstructionSimplify.h"
@@ -44,28 +45,38 @@
     bool runOnFunction(Function &F) {
       const DominatorTree *DT = getAnalysisIfAvailable<DominatorTree>();
       const TargetData *TD = getAnalysisIfAvailable<TargetData>();
+      SmallPtrSet<const Instruction*, 8> S1, S2, *ToSimplify = &S1, *Next = &S2;
       bool Changed = false;
-      bool LocalChanged;
 
       do {
-        LocalChanged = false;
-
         for (df_iterator<BasicBlock*> DI = df_begin(&F.getEntryBlock()),
              DE = df_end(&F.getEntryBlock()); DI != DE; ++DI)
           for (BasicBlock::iterator BI = DI->begin(), BE = DI->end(); BI != BE;) {
             Instruction *I = BI++;
-            // Don't bother simplifying unused instructions.
+            // The first time through the loop ToSimplify is empty and we try to
+            // simplify all instructions.  On later iterations ToSimplify is not
+            // empty and we only bother simplifying instructions that are in it.
+            if (!ToSimplify->empty() && !ToSimplify->count(I))
+              continue;
+            // Don't waste time simplifying unused instructions.
             if (!I->use_empty())
               if (Value *V = SimplifyInstruction(I, TD, DT)) {
+                // Mark all uses for resimplification next time round the loop.
+                for (Value::use_iterator UI = I->use_begin(), UE = I->use_end();
+                     UI != UE; ++UI)
+                  Next->insert(cast<Instruction>(*UI));
                 I->replaceAllUsesWith(V);
-                LocalChanged = true;
                 ++NumSimplified;
+                Changed = true;
               }
-            LocalChanged |= RecursivelyDeleteTriviallyDeadInstructions(I);
+            Changed |= RecursivelyDeleteTriviallyDeadInstructions(I);
           }
 
-        Changed |= LocalChanged;
-      } while (LocalChanged);
+        // Place the list of instructions to simplify on the next loop iteration
+        // into ToSimplify.
+        std::swap(ToSimplify, Next);
+        Next->clear();
+      } while (!ToSimplify->empty());
 
       return Changed;
     }