[llvm-commits] [llvm] r122581 - /llvm/trunk/lib/CodeGen/MachineVerifier.cpp

[Jakob Stoklund Olesen]

On Dec 26, 2010, at 9:17 PM, Cameron Zwarich wrote:

> Author: zwarich
> Date: Sun Dec 26 23:17:23 2010
> New Revision: 122581
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=122581&view=rev
> Log:
> Add knowledge of phi-def and phi-kill valnos to MachineVerifier's predecessor
> valno verification. The "Different value live out of predecessor" check is
> incorrect in the case of phi-def valnos, so just skip that check for phi-def
> valnos and instead check that all of the valnos for predecessors have phi-kill.
> Fixes PR8863.

Thanks, Cameron!

> +          if (VNI->isPHIDef() && VNI->def == LiveInts->getMBBStartIdx(MFI)) {

One thing is still missing: In this case, it is also legal for the live interval not to be live out of the predecessor. That can happen if a PHI operand was <undef>.

/jakob


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1929 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101227/d3963ec0/attachment.bin>