[llvm-commits] [PATCH] Two minor LNT improvements

Tobias Grosser grosser at fim.uni-passau.de
Mon Dec 27 08:45:33 PST 2010


Hi,

I like to commit those to changes to LNT:

* LNT: verify that --cc (and --cxx if provided) are valid paths


* LNT: Do not require the gcc extras string to be empty

Instead detect any gcc that is not an llvm-gcc. The case that triggered
this bug was a gcc with the following version string:
gcc (Ubuntu/Linaro 4.4.4-14ubuntu5) 4.4.5
It was not detected as a supported compiler, as cc_extra was ' ' instead
of the required ''. Now everything is allowed in cc_extra, just llvm-gcc
is filtered out and handled separately.

Patches attached. OK to commit?

Cheers
Tobi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-LNT-Do-not-require-the-gcc-extras-string-to-be-empty.patch
Type: text/x-diff
Size: 2386 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101227/74a0a872/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-LNT-verify-that-cc-and-cxx-if-provided-are-valid-pat.patch
Type: text/x-diff
Size: 1978 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101227/74a0a872/attachment-0001.patch>


More information about the llvm-commits mailing list