[llvm-commits] [Review request][Win] CMake & Lit: the new feature "LLVM_LIT_TOOLS_DIR"

[Óscar Fuentes]

NAKAMURA Takumi <geek4civic at gmail.com> writes:

> 2010/12/7 Óscar Fuentes <ofv at wanadoo.es>:
>>> +set(LLVM_LIT_TOOLS_DIR "" CACHE PATH "Path to GnuWin32 tools")
>>
>> I guess that other ports can be used (MSYS, Cygwin, etc) So instead of
>> GnuWin32 maybe you should list the names of the required tools (cmp,
>> sed, grep) on the docstring.
>>
>> +set(LLVM_LIT_TOOLS_DIR "" CACHE PATH
>> +   "Path to GNU cmp, grep and sed. Used when running tests.")
>
> I apologize to respond too later.
>
> I intended, for it, easier case. It might be specified only for
> gnuwin32 and would be useful on msbuild, mingw and msys.
>
> On cygwin, lit.tools_dir would not be used. Cygwin's python does not
> know he might be on win32 himself.
> (and in general, cygwin's toolchain should be mature)

Please note too that by mentioning GnuWin32 in the docstring the user
may think that it is required for running tests. Anyways, this is not a
reason for blocking the patch.