[llvm-commits] [llvm] r122341 - in /llvm/trunk: docs/TestingGuide.html test/lit.cfg utils/lit/lit/TestRunner.py

[David A. Greene]

Tobias Grosser <grosser at fim.uni-passau.de> writes:

>> Why not?  It's a tool name, right?
>
> Because until now only things prepended with % where replaced. So a
> check:
>
> ; RUN: opt %s -pass -analyze | grep "loop1: opt simple, loop2: opt none"
>
> Here 'opt' would be replaced, right?

Correct.

> Or if the tool is not freestanding. Maybe someone is using a shell
> subexpression to execute a tool:
>
> ; RUN: if `opt %s -pass -analyze | grep marker` : ...
>
> Whould 'opt' be replaced in this line?

Yes.  The matcher will replace "opt" in any "word" context, ewxcept for
some special cases (".opt", "-opt" and "^opt").

> Using %opt instead of opt is probably more obvious, however I believe
> this would complicate the test files unnecessarily.

Right.  A goal of this patch was to not require rewrites of all the
tests.

> No need to push my changes in. However if you agree it is a good
> thing, or at least does not hurt to fix the path order, I would go
> ahead and commit.

Go for it.  It shouldn't hurt anything.

                               -Dave