[llvm-commits] [llvm] r122341 - in /llvm/trunk: docs/TestingGuide.html test/lit.cfg utils/lit/lit/TestRunner.py

[David A. Greene]

Tobias Grosser <grosser at fim.uni-passau.de> writes:

> I just read your replies and have still an open question. You replied 
> the patch provided by me, that prepends the llvm tools directory to the 
> path will not solve the problem as it is too brittle. Can you explain this.

Because you never really know what else lit might prepend to the PATH,
as the PR demonstrates.  It's just more solid to say what you really
mean.  As a bonus, when things fail, the run script output by lit will
include the full paths so you know exactly what ran.

BTW, I just reverted the patch as it causes some darwin failures.  I
don't have a darwin system to test on and all the error message says is
"multiple repeat."  It means something is wrong with a regexp but I
don't have an easy way to figure out what.  Is anyone with a darwin
system able to investigate?  I'll blindly poke around for now.  :)

                       -Dave