[llvm-commits] [llvm] r121959 - /llvm/trunk/tools/llvm-dis/llvm-dis.cpp

[Frits van Bommel]

On Thu, Dec 16, 2010 at 5:36 AM, Daniel Dunbar <daniel at zuster.org> wrote:
>   OwningPtr<MemoryBuffer> BufferPtr;
>
> -  if (ec = MemoryBuffer::getFileOrSTDIN(InputFilename, BufferPtr))
> +  if ((ec = MemoryBuffer::getFileOrSTDIN(InputFilename, BufferPtr)))
>     ErrorMessage = ec.message();
>   else
>     M.reset(ParseBitcodeFile(BufferPtr.get(), Context, &ErrorMessage));
> -  MemoryBuffer *Buffer = BufferPtr.take();
> +  (void) BufferPtr.take();

Shouldn't this just use .take() instead of .get() in the 'else'
branch? (BufferPtr should be null if there was an error, right?)