[llvm-commits] [llvm] r121402 - /llvm/trunk/lib/MC/MCStreamer.cpp

[Rafael Ávila de Espíndola]

> This doesn't catch the Size = 1 and Value = 1UL<<63 case.  Use
> Value>  255U instead ?
>
>>     char buf[8];
>>     // FIXME: Endianness assumption.
>>     for (unsigned i = 0; i != Size; ++i)
>
> I've attached a small patch checking on more Value&  Size cases.  Please
> commit after review.

This patch would prevent us from doing EmitIntValue(-1, 1). Is that 
considered a good thing? A quick make check found just one case, so it 
is probably fine.

Maybe we should just check that the number is valid as a signed or 
unsigned value?

> John.

Cheers,
Rafael

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: t.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101213/9c290be6/attachment.ksh>