[llvm-commits] [llvm] r121732 - in /llvm/trunk: lib/MC/ELFObjectWriter.cpp test/CodeGen/ARM/2010-12-13-reloc-pic.ll

[Bill Wendling]

On Dec 13, 2010, at 3:16 PM, Jason W Kim wrote:

> Author: jasonwkim
> Date: Mon Dec 13 17:16:07 2010
> New Revision: 121732
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=121732&view=rev
> Log:
> First cut of ARM/MC/ELF PIC relocations.
> Test has fixme, to move to .s -> .o test when AsmParser works better.
> 
> 
> Added: llvm/trunk/test/CodeGen/ARM/2010-12-13-reloc-pic.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/2010-12-13-reloc-pic.ll?rev=121732&view=auto
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/2010-12-13-reloc-pic.ll (added)
> +++ llvm/trunk/test/CodeGen/ARM/2010-12-13-reloc-pic.ll Mon Dec 13 17:16:07 2010
> @@ -0,0 +1,100 @@
> +; RUN: llc  %s -mtriple=armv7-linux-gnueabi -arm-use-movt -relocation-model=pic -filetype=obj -o - | \
> +; RUN:    elf-dump --dump-section-data | FileCheck  -check-prefix=PIC01 %s
> +
> +;; Fixme: Reduce this test further, or even better, 

Hi Jason,

Small point: could you put the "Fixme" in upper case? That's typically what people do and it makes it easy to search for with grep.

-bw

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101213/b1369c9f/attachment.html>