[llvm-commits] [llvm] r121598 - /llvm/trunk/lib/Target/ARM/ARMMCCodeEmitter.cpp

Jim Grosbach grosbach at apple.com
Fri Dec 10 15:41:10 PST 2010


Author: grosbach
Date: Fri Dec 10 17:41:10 2010
New Revision: 121598

URL: http://llvm.org/viewvc/llvm-project?rev=121598&view=rev
Log:
Add FIXME

Modified:
    llvm/trunk/lib/Target/ARM/ARMMCCodeEmitter.cpp

Modified: llvm/trunk/lib/Target/ARM/ARMMCCodeEmitter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMMCCodeEmitter.cpp?rev=121598&r1=121597&r2=121598&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMMCCodeEmitter.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMMCCodeEmitter.cpp Fri Dec 10 17:41:10 2010
@@ -495,6 +495,8 @@
 uint32_t ARMMCCodeEmitter::
 getBranchTargetOpValue(const MCInst &MI, unsigned OpIdx,
                        SmallVectorImpl<MCFixup> &Fixups) const {
+  // FIXME: This really, really shouldn't use TargetMachine. We don't want
+  // coupling between MC and TM anywhere we can help it.
   const ARMSubtarget &Subtarget = TM.getSubtarget<ARMSubtarget>();
   if (Subtarget.isThumb2())
     return ::getBranchTargetOpValue(MI, OpIdx, ARM::fixup_t2_branch, Fixups);





More information about the llvm-commits mailing list