[llvm-commits] Fix floating point numbers in tests on MinGW

NAKAMURA Takumi geek4civic at gmail.com
Thu Dec 9 19:10:18 PST 2010


Good noon, Danil,

FYI, you may view tests here.
http://google1.osuosl.org:8011/builders/clang-i686-xp-msvc9

It is MSVC's, but you can see the issue you are working on.
You miss unittests.

2010/12/10 Danil Malyshev <dmalyshev at accesssoftek.com>:
> Cons:
> This patch changes the text output of floating numbers. Both variants (-1.300000e+01 and -1.300000e+001) correspond to the scientific format and will be properly recognized as a person and machine. Thus, this patch is not functional and rather cosmetic.
> In the changed operation still used printf. If again will differences in its output, it is can necessary again to change raw_ostream.

Sure, it would be also cosmetic tweak, though, it is needed for tests.
You know to read comments in the PR and we should implement
target-independent printer someday.

...Takumi



More information about the llvm-commits mailing list