[llvm-commits] [llvm] r120860 - /llvm/trunk/tools/lto/LTOCodeGenerator.cpp

[Rafael Espíndola]

>>> Do not try luck by using given name to create temporary file. In parallel builds it may not work.
>>
>> Is this a bug in the Path API?  The documentation says
>>
>>      bool createTemporaryFileOnDisk(
>>        bool reuse_current = false, ///< When set to true, this parameter
>>          ///< indicates that if the current file name does not exist then
>>          ///< it will be used without modification.
>>
>> So I would assume that if the name does exist a new one is created.
>
> After it is determine that name does not exit, but before the file with the name is created, someone else can also determine that name does not exit in a massively parallel build. "reuse_current = true" is not useful in parallel builds.

I would call that a bug in the API :-)

Michael, what about removing this feature from v2 if it cannot be
reliably implemented?

> -
> Devang

Cheers,
Rafael