[llvm-commits] [PATCH] Fix llvm.invariant support

Nick Lewycky nicholas at mxc.ca
Sun Dec 5 14:49:04 PST 2010


Kenneth Uildriks wrote:
> Here's the updated version.

Firstly, could you please reduce your tests? Try writing tests as .ll 
files by hand; they should be absolutely minimal to expose the 
optimization (or verify that we don't do an unsafe transformation).

+    DEBUG(errs() << "Invariant value is (" << *(BI->first) << ", "
+        << BI->second.Size << ")\n");
+    DEBUG(errs() << "Target is (" << *MemLoc.Ptr << ", " << MemLoc.Size
+        << ")\n");

These should be DEBUG(dbgs() << ...) not errs(). Please check all of them.

Nick



More information about the llvm-commits mailing list