[llvm-commits] Fix output stream opened in text instead of binary mode on MinGW

Danil Malyshev dmalyshev at accesssoftek.com
Fri Dec 3 16:01:15 PST 2010


> Could somebody apply this patch, please?

I just attach patch only for check_binary_output.ll


Thank you,
Danil

-----Original Message-----
From: Danil Malyshev 
Sent: Saturday, December 04, 2010 12:28 AM
To: 'NAKAMURA Takumi'
Cc: Chris Lattner; llvm-commits LLVM
Subject: RE: [llvm-commits] Fix output stream opened in text instead of binary mode on MinGW

Hi All,

Thank you for your review, Takumi.
Could somebody apply this patch, please?


Thank you,
Danil


-----Original Message-----
From: NAKAMURA Takumi [mailto:geek4civic at gmail.com] 
Sent: Thursday, December 02, 2010 12:40 PM
To: Danil Malyshev
Cc: Chris Lattner; llvm-commits LLVM
Subject: Re: [llvm-commits] Fix output stream opened in text instead of binary mode on MinGW

Applied to test/Archive/extract.ll in r120698 (with minor change).

test/Archive/check_binary_output.ll:
It looks good to me, it can detect failure if r120341 were not
applied. (confirmed on msvs10 and mingw)

...Takumi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test-archive-binary-output-03.diff
Type: application/octet-stream
Size: 467 bytes
Desc: test-archive-binary-output-03.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101203/ec9820e6/attachment.obj>


More information about the llvm-commits mailing list