[llvm-commits] [llvm] r120849 - /llvm/trunk/lib/Target/ARM/ARMInstrThumb.td

[Bill Wendling]

On Dec 3, 2010, at 3:02 PM, Jim Grosbach wrote:

> On Dec 3, 2010, at 2:58 PM, Bill Wendling wrote:
> 
>> On Dec 3, 2010, at 2:33 PM, Jim Grosbach wrote:
>> 
>>> Author: grosbach
>>> Date: Fri Dec  3 16:33:42 2010
>>> New Revision: 120849
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=120849&view=rev
>>> Log:
>>> Remove incorrect BL target encoding (it's similar to, but not the same as the
>>> ARM instruction). Add encoding of bits 13 and 11.
>>> 
>> Hi Jim,
>> 
>> Are bits 13 and 11 always supposed to be set? It looks like they're variable in the docs:
> 
> They're always set for the Thumb1 version, yes. If we need versions with them not set for T2, we'll want to add new patterns for them*.
> 
> It's kinda weird the way they document it. 
> 
> ARMv4T, ARMv5T*, ARMv6*, ARMv7 if J1 == J2 == 1
> ARMv6T2, ARMv7 otherwise
> 
Yes. I <3 ARM documentation. :)


Thanks.

-bw