[llvm-commits] [llvm] r120838 - in /llvm/trunk: lib/Target/ARM/InstPrinter/ARMInstPrinter.cpp test/CodeGen/Thumb2/large-stack.ll test/MC/Disassembler/ARM/thumb-tests.txt

[Jim Grosbach]

On Dec 3, 2010, at 2:53 PM, Chris Lattner wrote:

> 
> On Dec 3, 2010, at 12:33 PM, Jim Grosbach wrote:
> 
>> Author: grosbach
>> Date: Fri Dec  3 14:33:01 2010
>> New Revision: 120838
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=120838&view=rev
>> Log:
>> When using the 'push' mnemonic for Thumb2 stmdb, be explicit when it's the
>> 32-bit wide version by adding the .w suffix.
> 
> Hey Jim,
> 
> Why aren't the autogenerated forms of these instructions good enough?  Special c++ code in "printInst" should only be used for aliases.  Are these aliases?

Yes.

We try to canonicalize to using the "push" mnemonic to match the ARM docs. Adding the suffix resolves an ambiguity regarding which encoding is desired.

-Jim