[llvm-commits] [llvm] r120616 - /llvm/trunk/unittests/Support/Path.cpp

[Duncan Sands]

Hi Michael,

> Make valgrind happy.

valgrind is usually right, in which case reverse iterators are broken.
Do you plan to fix or remove them?

Best wishes, Duncan.

>
> Modified:
>      llvm/trunk/unittests/Support/Path.cpp
>
> Modified: llvm/trunk/unittests/Support/Path.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/Path.cpp?rev=120616&r1=120615&r2=120616&view=diff
> ==============================================================================
> --- llvm/trunk/unittests/Support/Path.cpp (original)
> +++ llvm/trunk/unittests/Support/Path.cpp Wed Dec  1 16:28:42 2010
> @@ -87,6 +87,7 @@
>       }
>       outs()<<  "]\n";
>
> +#if 0 // Valgrind is whining about this.
>       outs()<<  "    Reverse Iteration: [";
>       for (sys::path::reverse_iterator ci = sys::path::rbegin(*i),
>                                        ce = sys::path::rend(*i);
> @@ -95,6 +96,7 @@
>         outs()<<  *ci<<  ',';
>       }
>       outs()<<  "]\n";
> +#endif
>
>       bool      bres;
>       StringRef sfres;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits