[llvm-commits] [llvm] r120534 - in /llvm/trunk: lib/MC/ELFObjectWriter.cpp lib/Target/ARM/ARMAsmBackend.cpp test/CodeGen/ARM/2010-11-30-reloc-movt.ll

[Rafael Espíndola]

> Yes, that could be ok too, but that function will get larger as more
> relocations are added -
> helpers are usually considered to be "small", right?
>
> Honestly, I think its fine where it is, but if you really think it''s
> better to be outside the class, I'll move it out.

Having it out fo class does look more consistent with the rest. The
problem is not the size of the function (big functions, global or not,
should be broken into smaller ones (like you did on the writer :-) ).

> Thanks!
> -jason

Cheers,
Rafael