[llvm-commits] [llvm] r120534 - in /llvm/trunk: lib/MC/ELFObjectWriter.cpp lib/Target/ARM/ARMAsmBackend.cpp test/CodeGen/ARM/2010-11-30-reloc-movt.ll

[Rafael Espíndola]

>> It was a global static function before. Why can't you use it as such?
>
> It seemed like a better choice to move it to a canonical place for
> explicitly sharing between subclasses - that function was too close in
> the namespace tied to darwin.

Can you not just move it before both the Macho and ELF classes? I
don't see anything explicit about it in the coding standards, but the
example in "Anonymous Namespaces" seems to suggest that using a static
global helper would be better.

> Thanks!
>
> -jason

Cheers,
Rafael