[llvm-commits] [llvm] r120519 - in /llvm/trunk: lib/Transforms/Scalar/MemCpyOptimizer.cpp test/Transforms/MemCpyOpt/memcpy.ll
Chris Lattner
sabre at nondot.org
Tue Nov 30 17:24:55 PST 2010
Author: lattner
Date: Tue Nov 30 19:24:55 2010
New Revision: 120519
URL: http://llvm.org/viewvc/llvm-project?rev=120519&view=rev
Log:
fix a bozo bug I introduced in r119930, causing a miscompile of
20040709-1.c from the gcc testsuite. I was using the size of a
pointer instead of the pointee. This fixes rdar://8713376
Modified:
llvm/trunk/lib/Transforms/Scalar/MemCpyOptimizer.cpp
llvm/trunk/test/Transforms/MemCpyOpt/memcpy.ll
Modified: llvm/trunk/lib/Transforms/Scalar/MemCpyOptimizer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/MemCpyOptimizer.cpp?rev=120519&r1=120518&r2=120519&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/MemCpyOptimizer.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/MemCpyOptimizer.cpp Tue Nov 30 19:24:55 2010
@@ -814,7 +814,8 @@
// Find out what feeds this byval argument.
Value *ByValArg = CS.getArgument(ArgNo);
- uint64_t ByValSize = TD->getTypeAllocSize(ByValArg->getType());
+ const Type *ByValTy =cast<PointerType>(ByValArg->getType())->getElementType();
+ uint64_t ByValSize = TD->getTypeAllocSize(ByValTy);
MemDepResult DepInfo =
MD->getPointerDependencyFrom(AliasAnalysis::Location(ByValArg, ByValSize),
true, CS.getInstruction(),
Modified: llvm/trunk/test/Transforms/MemCpyOpt/memcpy.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/MemCpyOpt/memcpy.ll?rev=120519&r1=120518&r2=120519&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/MemCpyOpt/memcpy.ll (original)
+++ llvm/trunk/test/Transforms/MemCpyOpt/memcpy.ll Tue Nov 30 19:24:55 2010
@@ -77,3 +77,26 @@
declare void @test4a(i8* byval align 1)
declare void @llvm.memcpy.p0i8.p0i8.i64(i8* nocapture, i8* nocapture, i64, i32, i1) nounwind
+
+%struct.S = type { i128, [4 x i8]}
+
+ at sS = external global %struct.S, align 16
+
+declare void @test5a(%struct.S* byval align 16) nounwind ssp
+
+declare void @llvm.memcpy.p0i8.p0i8.i64(i8* nocapture, i8* nocapture, i64, i32, i1) nounwind
+
+; rdar://8713376 - This memcpy can't be eliminated.
+define i32 @test5(i32 %x) nounwind ssp {
+entry:
+ %y = alloca %struct.S, align 16
+ %tmp = bitcast %struct.S* %y to i8*
+ call void @llvm.memcpy.p0i8.p0i8.i64(i8* %tmp, i8* bitcast (%struct.S* @sS to i8*), i64 32, i32 16, i1 false)
+ %a = getelementptr %struct.S* %y, i64 0, i32 1, i64 0
+ store i8 4, i8* %a
+ call void @test5a(%struct.S* byval align 16 %y)
+ ret i32 0
+ ; CHECK: @test5(
+ ; CHECK: store i8 4
+ ; CHECK: call void @test5a(%struct.S* byval align 16 %y)
+}
More information about the llvm-commits
mailing list