[llvm-commits] Fix output stream opened in text instead of binary mode on MinGW

[Danil Malyshev]

Hi all,

Changed tests look good.

However, they will not catch the "output stream opened in wrong mode" issue.
llvm-ar produce binary output and this should be tested.
I propose a test to check this. The patch is attached.


Thank you,
Danil



-----Original Message-----
From: Chris Lattner [mailto:clattner at apple.com] 
Sent: Tuesday, November 30, 2010 9:13 PM
To: NAKAMURA Takumi
Cc: Danil Malyshev; llvm-commits LLVM
Subject: Re: [llvm-commits] Fix output stream opened in text instead of binary mode on MinGW


On Nov 30, 2010, at 6:39 AM, NAKAMURA Takumi wrote:

> Good evening Danil.
> 
> We should not rely on svn:eol-style nor eol-intolerant diff.exe.
> Some person does not use CRLF(eol-style=native) on windows (me, too).
> 
> I propose a patch. It is FileCheck-ized.

Looks great to me!  Please apply,

-Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test-archive-binary-output-01.diff
Type: application/octet-stream
Size: 527 bytes
Desc: test-archive-binary-output-01.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101130/7a24d293/attachment.obj>