[llvm-commits] Fix output stream opened in text instead of binary mode on MinGW

[Danil Malyshev]

Hello Chris,


> I don't understand or have an opinion on the archive tests though, can you explain it more?  Can someone on windows review them?

I apologize that I have not written in detail about the changes in the tests.

llvm-ar console output have Unix EOL style after my fix.
Archive tests use *.toc files for compare llvm-ar console output.
This files have Windows EOL style in the Windows OS because have property svn:eol-style=native.
So after my fix Archive tests will fails in the Windows.

I think, the best solution to this problem is delete property svn:eol-style=native in *.toc files, because the Subversion store files with this property in the Unix style.


Thank you,
Danil

________________________________
From: Chris Lattner [mailto:clattner at apple.com]
Sent: Tuesday, November 30, 2010 2:06 AM
To: Danil Malyshev
Cc: llvm-commits LLVM
Subject: Re: [llvm-commits] Fix output stream opened in text instead of binary mode on MinGW


On Nov 29, 2010, at 11:38 AM, Danil Malyshev wrote:


Hello Jakob,

> Can you find a way of doing this without increasing the size of the raw_ostream object, and without imposing any overhead on users that don't need it?

Ok, I did it.
Attached file fix-cout-02.diff is the new patch. It change only llvm-ar, llvm-ranlib, and attributes of *.toc files in Archive tests.

The llvm-ar and llvm-ranlib changes look great, committed in r120341.  I also removed the #include of <iostream>, saving us a static ctor.

I don't understand or have an opinion on the archive tests though, can you explain it more?  Can someone on windows review them?

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101130/0e63737b/attachment.html>