[llvm-commits] [llvm] r120404 - in /llvm/trunk: lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86ISelLowering.h lib/Target/X86/X86InstrSSE.td test/CodeGen/X86/apm.ll

[Eric Christopher]

> Minor and picky, but please wrap before 'MachineBasicBlock' so it isn't just a qualifier floating.
> 

I was wondering how I should indent that. :)

>> +let usesCustomInserter = 1 in {
>> +def MONITOR : I<0, Pseudo, (outs), (ins i32mem:$src1, GR32:$src2, GR32:$src3),
>> +                "# MONITORrrr PSUEDO",
>> +                [(int_x86_sse3_monitor addr:$src1, GR32:$src2, GR32:$src3)]>;
>> +def MWAIT : I<0, Pseudo, (outs), (ins GR32:$src1, GR32:$src2),
>> +                "# MWAITrr PSEUDO",
>> +                [(int_x86_sse3_mwait GR32:$src1, GR32:$src2)]>;
> 
> Please use an empty asmstring to avoid bloating the asmprinter tables.  Better yet, X86 should use a PseudoI<> class that does the right thing.

Got most of these handled, I'll get this next.

-eric