[llvm-commits] Fix output stream opened in text instead of binary mode on MinGW

[Danil Malyshev]

Hello Jakob,

> Can you find a way of doing this without increasing the size of the raw_ostream object, and without imposing any overhead on users that don't need it?

Ok, I did it.
Attached file fix-cout-02.diff is the new patch. It change only llvm-ar, llvm-ranlib, and attributes of *.toc files in Archive tests.


Thank you,
Danil

________________________________
From: Jakob Stoklund Olesen [mailto:stoklund at 2pi.dk]
Sent: Sunday, November 28, 2010 1:48 AM
To: Danil Malyshev
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] Fix output stream opened in text instead of binary mode on MinGW


On Nov 24, 2010, at 9:07 AM, Danil Malyshev wrote:

Hi Danil,

Thanks for working on this.


1. Adds support for setw() method to the llvm::raw_ostream.

Please don't do that, though. Part of the idea behind raw_ostream is that it doesn't have any of the overhead from formatting and so on.

Can you find a way of doing this without increasing the size of the raw_ostream object, and without imposing any overhead on users that don't need it?

Thanks,
/jakob

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101129/15b12036/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-cout-02.diff
Type: application/octet-stream
Size: 6257 bytes
Desc: fix-cout-02.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101129/15b12036/attachment.obj>