[llvm-commits] [Review request] Instcombine: extractvalue from load --> load from gep

[Dan Gohman]

On Nov 28, 2010, at 2:43 AM, Frits van Bommel wrote:

> On Sun, Nov 28, 2010 at 3:52 AM, Frits van Bommel <fvbommel at gmail.com> wrote:
>> No, definitely not okay. It inserts the new load at the location of
>> the extractvalue instead of the location of the old load. Fixed
>> version attached. I'll provide an extra test case once I've had some
>> sleep...
> 
> So apparently 4 AM is not the best time to try to fix bugs. Who knew?
> I forgot to even run the testcase.
> That version is even more broken than the one it replaced; it asserts
> every time it fires.
> 
> Here's the real fix, as well as the promised adjusted testcase that
> checks for the original problem.
> <006-instcombine-extractvalue-load-v3.patch><007-instcombine-extractvalue-load-test-v2.patch>_______________________________________________

Why is this needed? Front-ends should emit gep+load instead of
load+extractvalue.

Dan