[llvm-commits] [llvm] r120277 - in /llvm/trunk: lib/Target/ARM/ARMInstrThumb.td test/MC/ARM/thumb.s

[Chris Lattner]

Ok!!

On Nov 28, 2010, at 8:31 PM, Bill Wendling wrote:

> On Nov 28, 2010, at 8:29 PM, Chris Lattner wrote:
>> On Nov 28, 2010, at 8:23 PM, Bill Wendling wrote:
>> 
>>>> Each of these classes should use a base class to factor the commonality.  Within the classes, there are a lot of arbitrary naming decisions that differ, for example the operands of tRSB are Rn/Rd, the operands of tSXTB are Rm/Rd.
>>>> 
>>> 
>>> It's not arbitrary. We're trying to make the naming coincide with the documentation, which is how they name the operands for those instructions.
>> 
>> I believe you, but simpler .td files may result from using an actually-consistent naming scheme :)
>> 
> Indeed. :-) Like I said, I'm not finished with it just yet. Stayed tuned. :-)
> 
> -bw
>