[llvm-commits] [llvm] r120277 - in /llvm/trunk: lib/Target/ARM/ARMInstrThumb.td test/MC/ARM/thumb.s

[Bill Wendling]

On Nov 28, 2010, at 8:19 PM, Chris Lattner wrote:

> It looks like there are a couple of classes of things:
> 
> 1. Instructions with no operands that fill in constants, such as tNOP, tYIELD, etc.  These should use a base class or something to factor their let directives.
> 2. Some instructions use a reg + imm, such as tCMPzi8.
> 3. Some instructions use a reg+reg, such as tCMNz, tREV, tREV16, etc.
> 
Okay. Don't worry. I'm not yet done with the .td file. I haven't begun to refactor things in it yet. :)

> Each of these classes should use a base class to factor the commonality.  Within the classes, there are a lot of arbitrary naming decisions that differ, for example the operands of tRSB are Rn/Rd, the operands of tSXTB are Rm/Rd.
> 

It's not arbitrary. We're trying to make the naming coincide with the documentation, which is how they name the operands for those instructions.

-bw