[llvm-commits] [llvm] r120191 - in /llvm/trunk/tools: CMakeLists.txt Makefile macho-dump/ macho-dump/CMakeLists.txt macho-dump/Makefile macho-dump/macho-dump.cpp

[Chris Lattner]

On Nov 28, 2010, at 1:38 PM, Daniel Dunbar wrote:

> On Sun, Nov 28, 2010 at 11:23 AM, Chris Lattner <clattner at apple.com> wrote:
>> 
>> On Nov 26, 2010, at 9:58 PM, Daniel Dunbar wrote:
>> 
>>> Author: ddunbar
>>> Date: Fri Nov 26 23:58:44 2010
>>> New Revision: 120191
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=120191&view=rev
>>> Log:
>>> macho-dump: Stub out C++ macho-dump tool.
>> 
>> 
>> Ok, but why "macho-dump"?  Why not make it be "llvm-obj-dump" with a bunch of different flags?  Alternatively, it could be lumped in as a mode in llvm-mc.
> 
> Well, mostly because that is what the existing tool with the same
> functionality is called. I agree that long term making it some part of
> objdump makes sense, but there is a question as to whether that will
> be done through a generic interface as opposed to using the
> MachOObject directly.

I don't think it really matters: if "the objdump replacement" does so through generic interfaces, it can still have a mode that does the "macho-dump compatible" thing.  Just stay away from the standard objdump command line arguments.

-Chris