[llvm-commits] [llvm] r120165 - in /llvm/trunk: include/llvm/ADT/IntervalMap.h lib/Support/IntervalMap.cpp

Chris Lattner clattner at apple.com
Sun Nov 28 10:49:17 PST 2010


On Nov 25, 2010, at 5:39 PM, Jakob Stoklund Olesen wrote:

> Author: stoklund
> Date: Thu Nov 25 19:39:40 2010
> New Revision: 120165
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=120165&view=rev
> Log:
> Move tree navigation to a new Path class that doesn't have to be a template.
> 
> The path also holds a reference to the root node, and that allows important
> iterator accessors like start() and stop() to have no conditional code. (When
> the compiler is clever enough to remove it.)

Ok
> 
> +//===----------------------------------------------------------------------===//
> +//---                                  Path                                ---//
> +//===----------------------------------------------------------------------===//

Random request, in the comment header, please use "IntervalMapImpl::Path" instead of just Path.  I was about to ask you not to name this something generic like Path, but being in a namespace makes it ok :-)

-Chris





More information about the llvm-commits mailing list