[llvm-commits] Fix output stream opened in text instead of binary mode on MinGW

Danil Malyshev dmalyshev at accesssoftek.com
Wed Nov 24 09:07:58 PST 2010


Hello everyone,

Please find attached a patch to review.

This patch

1. Adds support for setw() method to the llvm::raw_ostream.
2. Changes llvm-ar, and llvm-ranlib  to use llvm::raw_ostream instead of std::cout.
3. Removes attribute: svn: eol-style = native for some toc files to make it similar with the rest of them.

This should fix some issues with the output stream opened in text instead of binary mode on Windows.



P.S.

By the way, I see inconsistency in SVN attributes set for files in the test/Archive directory. What is the policy for this? Does it make sense to remove all attributes or add missing ones?


Thank you,
Danil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101124/03c8d893/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-cout-01.diff
Type: application/octet-stream
Size: 8240 bytes
Desc: fix-cout-01.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101124/03c8d893/attachment.obj>


More information about the llvm-commits mailing list