[llvm-commits] [Review request] test: Add the new feature "loadable_module"

[Rafael Espíndola]

2010/11/22 NAKAMURA Takumi <geek4civic at gmail.com>:
> Good evening.
>
> I re-assembled my patches.
> Excuse me, please take a look, thank you.
>
> * 0001-test-Add-the-new-feature-loadable_module.patch
> (application/octet-stream) 2K


+# Loadable module
+# FIXME: This should be supplied by Makefile or autoconf.
+if sys.platform in ['win32', 'cygwin']:
+    loadable_module = (config.enable_shared == 1)

Why can't you use config.enable_shared in every platform?

>  Same as the last one. It adds the feature but do nothing.
>
> * 0002-test-Use-SharedLibDir-for-loadable-modules.-On-Cygmi.patch
> (application/octet-stream) 5K
>
>  It passes $SharedLibDir to lit.

-            'link', 'shlibext', 'ocamlopt', 'llvmdsymutil', 'llvmlibsdir',
+            'link', 'ocamlopt', 'llvmdsymutil', 'llvmlibsdir',
+            'llvmshlibdir', 'shlibext',
             'bugpoint_topts']:

Why the reordering?


> * 0003-Makefile-Change-the-order-of-building-lib-Transforms.patch
> (application/octet-stream) 2K
>
>  It changes the order of building "LLVMHello" after building tools.
>  On cygming, LLVMHello.dll can be built after LLVM.dll.

OK

> * 0004-tools-Makefile-Enable-building-lto-edis-and-bugpoint.patch
> (application/octet-stream) 2K
>
>  It enables building butpoint-passes, edis and LTO on Cygming.
>  bugpoint-passes can be built with LLVM.dll.

OK, but please reindent the code in the ifdef.

> * 0005-test-Check-the-feature-loadable_module-with-load-mod.patch
> (application/octet-stream) 4K
>
>  It enables tests.
>
>
> ...Takumi
>

Cheers,
Rafael