[llvm-commits] Review request: dominance frontier computation speedup

Cameron Zwarich zwarich at apple.com
Tue Nov 23 23:40:34 PST 2010


On 2010-11-23, at 11:34 PM, Cameron Zwarich wrote:

>> Looks good to me. Are you going to replace std::map with DenseMap as well?
> 
> I was considering it, but I wasn't sure about the memory footprint of a DenseMap with SmallPtrSet elements. I guess they could all be allocated with a PtrBumpAllocator if it is a performance issue, but it is still wasted memory.

Oops. That last sentence doesn't make sense. If a PtrBumpAllocator is used, then the unused slots won't waste memory.

Cameron



More information about the llvm-commits mailing list