[llvm-commits] Review request: dominance frontier computation speedup

[Jakob Stoklund Olesen]

On Nov 23, 2010, at 9:27 PM, Cameron Zwarich wrote:

> There aren't very many good use cases for std::set. Most dominance frontiers are small, so a SmallPtrSet seemed like a good choice. I experimented with different small values of the inline capacity and found that 2 was best for performance.

Does the majority of sets really have only 2 or less members? Otherwise, a DenseSet might be better.

> This is an 18% speedup running domfrontier on test-suite + SPEC2000.
> 
> <domfrontier-set.patch>

Looks good to me. Are you going to replace std::map with DenseMap as well?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1929 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101123/fd4f4172/attachment.bin>